Add @$_CSharpKeyword F1 keyword to tokens index#20197
Merged
BillWagner merged 1 commit intodotnet:masterfrom Aug 26, 2020
Merged
Add @$_CSharpKeyword F1 keyword to tokens index#20197BillWagner merged 1 commit intodotnet:masterfrom
BillWagner merged 1 commit intodotnet:masterfrom
Conversation
Member
Author
|
@BillWagner Since I got approval from @davidwengier on Roslyn PR. I think this is ready to merge (unless you see a better page for this F1 keyword). |
BillWagner
approved these changes
Aug 25, 2020
Member
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM @Youssef1313
I'll 
now.
Member
Author
|
@BillWagner Anything left for this? |
Member
|
Thanks for the ping @Youssef1313 I did everything but press the "merge" button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to merge this before finishing the work in dotnet/roslyn#46987 and getting approval there.