Conversation
| - "CS0003" | ||
| - "CS0004" | ||
| - "CS0008" | ||
| - "CS0012" |
There was a problem hiding this comment.
This is one example where the error message is already documented but existed here. So, this f1 keyword was duplicated in this file and in the actual documentation.
There was a problem hiding this comment.
@BillWagner, while I was testing what Visual Studio will do in the case of duplicated f1 keywords in multiple articles, I noticed that all error messages goes to a Bing search after clicking F1. So, the f1_keywords metadata seems to be not working at all.
I opened an issue for that. dotnet/roslyn#46829
There was a problem hiding this comment.
Hi 👋 I dug into this problem before, see dotnet/roslyn#40863 and #16448. I think the main sticking point was finding out what the new link should be for the f1 service - as I presume the msdn URL for is now deprecated.
If you did want to take it further, the NuGet repo has a good example, as it's set up to work for their error codes. Should be a fairly easy thing to implement, once someone can find out what that links meant to be! 😄
There was a problem hiding this comment.
Hi 👋 I dug into this problem before, see dotnet/roslyn#40863 and #16448. I think the main sticking point was finding out what the new link should be for the f1 service - as I presume the msdn URL for is now deprecated.
If you did want to take it further, the NuGet repo has a good example, as it's set up to work for their error codes. Should be a fairly easy thing to implement, once someone can find out what that links meant to be! 😄
There was a problem hiding this comment.
@ChrisMaddock Thanks!! That's really really useful.
What I can't understand is, what's the problem to hook the error messages with the link https://msdn.microsoft.com/query/dev16.query?appId=Dev16IDEF1&l=EN-US&k=k(ERROR_ID);k(DevLang-csharp)&rd=true..
cc: @mairaw
There was a problem hiding this comment.
I'd presumed that link should be deprecated, given we've been replacing MSDN links everywhere else. There was a couple of other questions around filling in the appropriate appId and culture, but I assume that info is discoverable within Roslyn in some way. I think I was waiting on more info as to the official link we should be using here, and then other priorities came up, as they always do. 😄
I'm not a Microsoft employee though - just a guy with a lot of compiler errors! So perhaps best to hear from the experts instead. :-)
There was a problem hiding this comment.
@ChrisMaddock The f1 for keywords in the latest visual studio still uses that msdn link. If you, for example, press f1 on an await keyword in the latest visual studio, it will open a similar msdn link.
Based on the fact that C# keywords using that same link, I don't think see a problem using that same link too for error messages. I'll wait for someone to confirm.
There was a problem hiding this comment.
Great! 😄 Hope it gets merged soon!
There was a problem hiding this comment.
@ChrisMaddock I hope that too.
and many thanks for the information you provided, which is incredibly helpful.
BillWagner
left a comment
There was a problem hiding this comment.
After all this work, I think this is ready.
It will also help us have a list of those warnings we haven't documented.
Thanks @Youssef1313
This is the code I used to generate this:
Important note
This relies on the currently defined error numbers in dotnet/roslyn repository, error numbers that were retired won't now exist. (I think that should be okay since Visual Studio wasn't relying (and still not relying) on f1, which may be fixed in dotnet/roslyn#46850)
Fixes #20034