Enable BuildKit in ImageBuilder#1132
Merged
lbussell merged 3 commits intodotnet:mainfrom Apr 19, 2023
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
mthalman
reviewed
Apr 18, 2023
mthalman
reviewed
Apr 18, 2023
mthalman
approved these changes
Apr 19, 2023
Member
|
I'm concerned that this may have affected the metadata of the outputted image. It doesn't look like the architecture variant is getting set for the built image (specific to Arm). This build result is an example of the issue. @lbussell - Can you investigate this? |
Member
Author
|
Couple findings -
I also retried failed jobs on that pipeline and it still had the same error. This feels like a bug somewhere in ImageBuilder and requires more investigation, so for now I have prepared a PR that reverts the BuildKit changes: #1136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to facilitate dotnet/dotnet-docker#4447 and dotnet/dotnet-docker#4542