Update to Microsoft.CodeAnalysis 3.3.1#5163
Merged
superyyrrzz merged 3 commits intodotnet:devfrom Oct 12, 2019
Merged
Conversation
|
|
Contributor
Author
|
Related: #4952 |
Contributor
|
CI build failed. We may need to update some tests cases: |
Contributor
Author
|
The current https://docfx.visualstudio.com/docfx/_build/results?buildId=964 |
Contributor
|
@dlech You are right. I will fix dev branch first. |
This updates to the latest Microsoft.CodeAnalysis packages for C#8 support. Fixes the following error on a project that uses nullable reference types: Microsoft.DocAsCode.Exceptions.DocfxException: Unable to generate spec reference for !: ---> System.IO.InvalidDataException: Fail to parse id for symbol in namespace . at Microsoft.DocAsCode.Metadata.ManagedReference.YamlModelGenerator.AddSpecReference (Microsoft.CodeAnalysis.ISymbol symbol, System.Collections.Generic.IReadOnlyList`1[T] typeGenericParameters, System.Collections.Generic.IReadOnlyList`1[T] methodGenericParameters, System.Collections.Generic.Dictionary`2[TKey,TValue] references, Microsoft.DocAsCode.Metadata.ManagedReference.SymbolVisitorAdapter adapter) [0x0005e] in <27b606b838ab45b788854d5e45efa610>:0 at Microsoft.DocAsCode.Metadata.ManagedReference.SymbolVisitorAdapter.AddSpecReference (Microsoft.CodeAnalysis.ISymbol symbol, System.Collections.Generic.IReadOnlyList`1[T] typeGenericParameters, System.Collections.Generic.IReadOnlyList`1[T] methodGenericParameters) [0x00000] in <27b606b838ab45b788854d5e45efa610>:0
Since updating Microsoft.CodeAnalysis to 3.3.1, the automatic formatting for tuples in C# has been fixed, so update tests accordingly. dotnet/roslyn#29405
Since updating to Microsoft.CodeAnalysis 3.3.1, the default keyword is resolved to a vaule instead of the a default expression. Probably comes from dotnet/roslyn#37596
Contributor
Author
|
Thanks. I have fixed the tests that were failing because of the upgraded packages. |
Contributor
|
@dlech Thank you for the contribution! |
superyyrrzz
approved these changes
Oct 12, 2019
This was referenced Oct 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to the latest Microsoft.CodeAnalysis packages for C#8 support.
Fixes the following error on a project that uses nullable reference types:
Microsoft Reviewers: Open in CodeFlow