Fix #9990 header and footer template files #10012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to be added to the toc.yml
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10012 +/- ##
==========================================
+ Coverage 74.31% 78.86% +4.54%
==========================================
Files 536 540 +4
Lines 23189 23482 +293
Branches 4056 4067 +11
==========================================
+ Hits 17234 18518 +1284
+ Misses 4853 3822 -1031
- Partials 1102 1142 +40 ☔ View full report in Codecov by Sentry. |
yufeih
reviewed
Jun 18, 2024
| static string? GetHeaderFooter(string? template) | ||
| { | ||
| return File.Exists(template) | ||
| ? File.ReadAllText(template) |
Contributor
There was a problem hiding this comment.
Where is the current directory if this is a relative path? Consider explicitly state the base directoy to relative to
Contributor
|
Close in favor of #10099 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reading of file, instead of only allowing the template to be added to the toc.yml