-
Notifications
You must be signed in to change notification settings - Fork 884
Closed
Labels
fundamentalEngineering system and core componentsEngineering system and core components
Description
Is your feature request related to a problem? Please describe.
Currently CI workflow(ci,yml) don't validate snapshot HTML.
(Because BUILD_SERVER environment variable is not set)
And Snapshot HTML is not updated since Percy Test is introduced.
So it cause diffs when running tests on local environment.
Describe the solution you'd like
Add separated CI workflow to update snapshot HTMLs.
This workflow should be invoked with workflow_dispatch trigger.
Because GitHub action workflows don't allow to invoke another workflow(ci.yml) within a workflow except for workflow_dispatch trigger.
Expected steps to update snapshot
- Manually invoke snapshot update workflow from GitHub Action UI or
gh workflow runcommand. - Run snapshot tests.
- If diffs exists after tests. Commit diff files. and invoke
ci.ymlworkflow.
Metadata
Metadata
Assignees
Labels
fundamentalEngineering system and core componentsEngineering system and core components