Skip to content

Allow major roll-forward for Secret Manager#6425

Merged
premun merged 1 commit intomainfrom
premun-patch-1
Nov 21, 2025
Merged

Allow major roll-forward for Secret Manager#6425
premun merged 1 commit intomainfrom
premun-patch-1

Conversation

@premun
Copy link
Copy Markdown
Member

@premun premun commented Nov 20, 2025

We tried to run it with .NET 10.0 in arcade-services and it didn't work.

We also tried to override it and also didn't work: dotnet/arcade-services#5546

@premun premun requested review from a team and adamzip November 20, 2025 16:58
@premun premun enabled auto-merge (squash) November 20, 2025 22:18
@garath
Copy link
Copy Markdown
Member

garath commented Nov 21, 2025

Hm, maybe I'm misunderstanding how roll-forward works here. I thought it would only affect what SDK the project uses at build-time, and compile-time will just require something compatible with the specified TFM. And if that's true I think the easiest way to unblock yourself is to add net8 to the machine for that step. I'll do some reading...

@garath
Copy link
Copy Markdown
Member

garath commented Nov 21, 2025

Oh, yep, I had this confused with "RollForward" in global.json. This doc says it indeed will work for runtime choices.

I wonder if it would be better or worse to multitarget.

@premun premun merged commit 79ac702 into main Nov 21, 2025
5 of 6 checks passed
@premun premun deleted the premun-patch-1 branch November 21, 2025 02:18
@premun
Copy link
Copy Markdown
Member Author

premun commented Nov 21, 2025

Thanks, it worked!

https://dev.azure.com/dnceng/internal/_build/results?buildId=2844355&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants