Enable disasm mixed gc info#403
Conversation
Rewrite the "u -gcinfo" code to not require Windows fibers, and enable it for non-Windows platforms. Also, 1. Enable "u -gcinfo" for ARM. 2. Fix minor issues with EHinfo/GCinfo to ensure end-of-function info is displayed
|
@mikem8361 PTAL. I've tested this works still on Windows/x64. I'm having trouble building on Ubuntu 16.04 x64, but obviously that's the real test. I'm also trying to test on Windows arm32, since I enabled that for "!gcinfo" as well. |
|
|
||
| void GCEncodingInfo::Deinitialize() | ||
| { | ||
| delete[] buf; |
There was a problem hiding this comment.
I can't remember for sure, but does delete check for null? Do you need to check buf for nullptr first?
There was a problem hiding this comment.
delete does accept nullptr (presumably it hasn't been overridden by an implementation that does not handle it)
mikem8361
left a comment
There was a problem hiding this comment.
Looks good. Thanks for doing this.
|
Fixes #54 |
|
@mikem8361 Does the diagnostics repo have Azure DevOps CI testing for PRs? E.g., something that builds and run tests on all architectures? |
|
I was able to build and test this on Linux/x64, so this is no longer WIP. |
Rewrite the "u -gcinfo" code to not require Windows fibers,
and enable it for non-Windows platforms.
Also,