Skip to content

Update SOS for when the portable thread pool is used for IO completions on Windows#2870

Merged
kouvel merged 1 commit intodotnet:mainfrom
kouvel:TpIoWinDiag
Mar 4, 2022
Merged

Update SOS for when the portable thread pool is used for IO completions on Windows#2870
kouvel merged 1 commit intodotnet:mainfrom
kouvel:TpIoWinDiag

Conversation

@kouvel
Copy link
Contributor

@kouvel kouvel commented Feb 13, 2022

Update SOS for when the portable thread pool is used for IO completio…
433dbd1 
…ns on Windows

- Depends on dotnet/runtime#64834
- Refactored the enumeration of the global queue and reused it to also enumerate the high-priority work item queue
- Omitted info that is specific to the native thread pool implementation, when the portable thread pool is being used for IO completions
@kouvel kouvel added this to the .NET 7.0 milestone Feb 13, 2022
@kouvel kouvel requested a review from a team as a code owner February 13, 2022 04:16
@kouvel kouvel self-assigned this Feb 13, 2022
@kouvel
Copy link
Contributor Author

kouvel commented Feb 13, 2022 •
edited
Loading

  • The refactor seems to be difficult to diff on GitHub, for an easier review I have shared a diff of the relevant sections of the refactor here (download the file and open in browser)
  • Verified that the changed version of SOS works before the change

@kouvel kouvel merged commit ac1d5cf into dotnet:main Mar 4, 2022
@kouvel kouvel deleted the TpIoWinDiag branch March 4, 2022 21:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mikem8361 mikem8361 mikem8361 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kouvel kouvel

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kouvel @mikem8361