Skip to content

Add IsStdioMode property and update plugin URL validation logic. Closes #1519#1523

Merged
garrytrinder merged 4 commits intodotnet:mainfrom
waldekmastykarz:fix/1519-plugins-no-urls
Feb 24, 2026
Merged

Add IsStdioMode property and update plugin URL validation logic. Closes #1519#1523
garrytrinder merged 4 commits intodotnet:mainfrom
waldekmastykarz:fix/1519-plugins-no-urls

Conversation

@waldekmastykarz
Copy link
Collaborator

Add IsStdioMode property and update plugin URL validation logic. Closes #1519

@waldekmastykarz waldekmastykarz requested a review from a team as a code owner February 7, 2026 10:48
Copilot AI review requested due to automatic review settings February 7, 2026 10:48
@waldekmastykarz waldekmastykarz added the pr-bugfix Fixes a bug label Feb 7, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes plugin loading failures for devproxy stdio runs when no urlsToWatch are configured, aligning plugin URL validation with STDIO/JSON-RPC usage (closes #1519).

Changes:

  • Adds IsStdioMode to early-parsed CLI options to detect stdio invocation.
  • Updates plugin registration to only enforce “at least one URL to watch” when not running in STDIO mode.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
DevProxy/Plugins/PluginServiceExtensions.cs Passes STDIO mode into plugin registration and skips URL-to-watch enforcement when running in STDIO mode.
DevProxy/Commands/DevProxyConfigOptions.cs Introduces IsStdioMode based on the parsed subcommand name (stdio).

@garrytrinder
Copy link
Contributor

@waldekmastykarz can you take a look at the merge conflicts, thank you

garrytrinder
garrytrinder previously approved these changes Feb 24, 2026
@garrytrinder garrytrinder enabled auto-merge (squash) February 24, 2026 13:24
@garrytrinder garrytrinder merged commit 09cad38 into dotnet:main Feb 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Error with Urls to Watch when using MockStdioResponsePlugin / DevToolsPlugin combination

3 participants