PR feedback on the "verifiable ref returns" proposal#31
Merged
VSadov merged 3 commits intodotnet:masterfrom Jan 25, 2018
Merged
PR feedback on the "verifiable ref returns" proposal#31VSadov merged 3 commits intodotnet:masterfrom
VSadov merged 3 commits intodotnet:masterfrom
Conversation
Member
Author
|
@MichalStrehovsky - please take a look. After thinking a bit about whether IsReturnable should be an attribute, I am getting convinced that it should be just a regular class like IsConst. Its only foreseeable target is IL local slots and that is not even expressible in AttributeTargets enum. - Making this type an attribute seems unnecessary and perhaps confusing. |
MichalStrehovsky
approved these changes
Jan 25, 2018
Member
Author
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.