Enable source-build pre-built detection #266
Conversation
| <UsagePattern IdentityGlob="*/*" /> | ||
| <UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*/*" /> | ||
|
|
||
| <!-- Ignore System.Text.JSon 7.0.1 and dependencies until we can add |
There was a problem hiding this comment.
Would be IMO good to open a tracking issue for this and add it to the comment prior to merging.
There was a problem hiding this comment.
Would be IMO good to open a tracking issue for this and add it to the comment prior to merging.
Yeah, meant to do that originally - working on it now.
| <UsagePattern IdentityGlob="System.Text.Json/7.0.1" /> | ||
| <UsagePattern IdentityGlob="Microsoft.Bcl.AsyncInterfaces/7.0.0" /> | ||
| <UsagePattern IdentityGlob="System.Text.Encodings.Web/7.0.0" /> |
There was a problem hiding this comment.
Curious, why can't those be live references from runtime?
There was a problem hiding this comment.
Because we should not introduce more places where we need to worry about coherency :)
There was a problem hiding this comment.
I thought that live dependencies are always preferred over SBRP (for obvious reasons). deployment-tools is part of the VMR. Is another node repo node in the graph that bad?
There was a problem hiding this comment.
It's bad in context of the current build. That means every time we have a servicing patch, preview, etc. We have yet another parallel path to flow runtime through before we can release the product. We only really need to depend on live dependencies where the consuming repo repackages meaningful info about the dependency. For instance, the SDK will repackage the actual binaries, so it needs to depend on the latest. Consider roslyn, it targets net6 in it's build, but inserts into the SDK. It rolls forward to run on the SDK runtime.
Fixes: #264