Address conversions of conditional accesses in IDA#4554
Merged
RikkiGibson merged 7 commits intomainfrom Mar 23, 2021
Merged
Conversation
333fred
approved these changes
Mar 22, 2021
jcouv
reviewed
Mar 23, 2021
jcouv
approved these changes
Mar 23, 2021
Member
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (iteration 5) modulo some minor typography
RikkiGibson
commented
Mar 23, 2021
Member
Author
|
The amount of "not"s in the spec language is not ideal, but it is accurate, at least, and hopefully the remarks helps to make it comprehensible 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It feels like we can't propagate "state when not null" out of conditional accesses when they are subject to certain user-defined conversions, but it is desirable to propagate out such state from built-in implicit and explicit conversions whenever possible.