This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merged
Conversation
This change enables parallelization of ILC compilation when building multiple assemblies. For the CoreCLR framework I'm observing about 3~4 times compilation time speedup (about 33 seconds where previously I was observing about 120 seconds with SuperIlc and about 180 seconds with the legacy scripts). Thanks Tomas
nattress
reviewed
Mar 19, 2019
| @@ -0,0 +1,160 @@ | |||
| using System; | |||
Contributor
There was a problem hiding this comment.
Could you add the copyright header
Member
Author
There was a problem hiding this comment.
Hmm, for sure, sorry about missing it again :-).
nattress
reviewed
Mar 19, 2019
| public string LogPath; | ||
| public int TimeoutMilliseconds = DefaultTimeout; | ||
| public int ExpectedExitCode; | ||
| public object Data; |
Contributor
There was a problem hiding this comment.
Can we strongly type this and use a meaningful name, ie, FileName?
Member
Author
There was a problem hiding this comment.
OK, will do, I was originally thinking it might also serve other purposes but I agree it's better not to introduce speculative code.
Based on Simon's PR feedback I have renamed ProcessInfo.Data to InputFileName and I made it a string. As I've introduced a subfolder per compiler name (ilc / crossgen), I could relax the requirement for output directory specification (because it can default to the input folder) and the check for input folder being a subfolder of the output folder. Thanks Tomas
nattress
reviewed
Mar 19, 2019
| try | ||
| { | ||
| outputDirectory.Delete(recursive: true); | ||
| Directory.Delete(runnerOutputPath, recursive: true); |
Contributor
There was a problem hiding this comment.
Nit: Could you update the error message in the catch to refer to runnerOutputPath instead of the now potentially incorrect outputDirectory?
Emit the process name, arguments, duration and exit status into the process log file. I have also added calls to WaitForExit() to flush buffered stdout / stderr outputs. Thanks Tomas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables parallelization of ILC compilation when building
multiple assemblies. For the CoreCLR framework I'm observing about
3~4 times compilation time speedup (about 33 seconds where
previously I was observing about 120 seconds with SuperIlc and
about 180 seconds with the legacy scripts).
Thanks
Tomas