This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Fix MethodDesc.ToString in runtime type loader#5263
Merged
MichalStrehovsky merged 1 commit intodotnet:masterfrom Jan 19, 2018
Merged
Fix MethodDesc.ToString in runtime type loader#5263MichalStrehovsky merged 1 commit intodotnet:masterfrom
MichalStrehovsky merged 1 commit intodotnet:masterfrom
Conversation
The full `ToString` implementation includes the signature to help diagnosability, but the runtime type loader might not be able to provide that information. Stop including MethodDesc.ToString.cs in the runtime type loader and restore old overrides on `MethodForInstantiatiatedType` and `InstantiatedMethod` that got deleted in dotnet#5065 (but only for the runtime type loader). Also fixing up the the project file: * The tracing options should also be available in CoreRT * Deleting `TYPE_SYSTEM_SINGLE_THREADED` that got introduced in TFS changeset 1553623 and got never used for anything
Member
Author
|
@fadimounir PTAL |
|
LGTM. Thanks for fixing the logging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full
ToStringimplementation includes the signature to help diagnosability, but the runtime type loader might not be able to provide that information.Stop including MethodDesc.ToString.cs in the runtime type loader and restore old overrides on
MethodForInstantiatiatedTypeandInstantiatedMethodthat got deleted in #5065 (but only for the runtime type loader).Also fixing up the the project file:
TYPE_SYSTEM_SINGLE_THREADEDthat got introduced in TFS changeset 1553623 and got never used for anything