ILVerify: split into exe and library#5258
Conversation
|
Hum, it looks like I need to work on the command-line build, as CI produced: |
|
LGTM! Out of personal interest: Do you think it would be a desirable goal to change the code at some point, to only rely on the public interface without having to expose internals to both ILVerify and the Tests projects? |
Yes, it would be definitely a desirable goal. |
| @@ -0,0 +1,3 @@ | |||
| # ILVerification | |||
|
|
|||
| The ILVerification library is part of the ILVerify project. See details under [src/ILVerify/](https://github.com/dotnet/corert/tree/master/src/ILVerify). No newline at end of file | |||
There was a problem hiding this comment.
Nit: It would be nice to use relative URLs for the relative tree links so that the links stay valid when the repo is forked or branched.
Per discussion in #5235, the library code and corresponding tests go into
src/ILVerification, while the command-line exe is produced fromsrc/ILVerify.I kept a single solution (under
ILVerify) which points to the three projects.Aside from solution and project file changes, the code changes were:
Program.cswas removed fromILVerificationand moved toILVerify.ILVerificationchanged name.InternalsVisibleTotoILVerify.Fixes #5235
Relates to dotnet/roslyn#22872
Tagging @jkotas @ArztSamuel @A-And