This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Fix CleanupStub for Struct Marshalling with static fields#3695
Merged
shrah merged 1 commit intodotnet:masterfrom May 25, 2017
Merged
Fix CleanupStub for Struct Marshalling with static fields#3695shrah merged 1 commit intodotnet:masterfrom
shrah merged 1 commit intodotnet:masterfrom
Conversation
nattress
approved these changes
May 25, 2017
Contributor
nattress
left a comment
There was a problem hiding this comment.
Nit: It would be slight working set win if EcmaType.GetFieldMarshalAsDescriptors didn't return an array of MarshalAsDescriptors that's got nulls on the end when static fields are present. Not going to block check-in on that though since ASP.NET has only one of those.
Contributor
|
Thanks for the quick fix! |
Contributor
Author
|
@nattress good point. I will follow that up on a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nattress PTAL