This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Replace some runtime asserts with better type declarations.#3681
Merged
1 commit merged intonmirrorfrom May 23, 2017
unknown repository
Merged
Replace some runtime asserts with better type declarations.#36811 commit merged intonmirrorfrom unknown repository
1 commit merged intonmirrorfrom
unknown repository
Conversation
The prior commit added some runtime assertions for conditions that we were taking new dependencies on. This commits replaces those assertions with more specific type declarations so all this can be enforced at compile-time.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior commit added some runtime assertions for
conditions that we were taking new dependencies on.
This commits replaces those assertions with more
specific type declarations so all this can be enforced
at compile-time.