This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Restore ability to compile against Test.CoreLib#3674
Merged
jkotas merged 3 commits intodotnet:masterfrom May 23, 2017
Merged
Conversation
Building against the lightweight version of S.P.CoreLib has bitrotted over the past year. The classlib is handy for codegen and architecture bringups and we might want to use it when getting rid of ready to run helpers.
jkotas
reviewed
May 22, 2017
src/JitInterface/src/CorInfoImpl.cs
Outdated
| CorInfoType type = asCorInfoType(fieldType, out structType); | ||
|
|
||
| Debug.Assert(_compilation.TypeSystemContext.GetWellKnownType(WellKnownType.ByReferenceOfT).GetKnownField("_value").FieldType.Category == TypeFlags.IntPtr); | ||
| Debug.Assert(_compilation.TypeSystemContext.GetWellKnownType(WellKnownType.ByReferenceOfT, false) == null || |
Member
There was a problem hiding this comment.
This is relatively expensive to execute for every getFieldType even before this change. Change it to:
Debug.Assert(fieldDesc.OwningType.IsByReferenceOfT && ... the long condition here ...)
?
Member
Author
There was a problem hiding this comment.
It also ended up being shorter. Thanks!
jkotas
approved these changes
May 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building against the lightweight version of S.P.CoreLib has bitrotted
over the past year. The classlib is handy for codegen and architecture
bringups and we might want to use it when getting rid of ready to run
helpers.