This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merged
Conversation
With some changes I have in flight `GetFinalizer` in compiler traces went from "might be worth looking into making this faster" to "we spend 15% of compilation time here". The answer to `HasFinalizer` is cheap to cache and reduces the pressure on `GetFinalizer` significantly.
jkotas
approved these changes
May 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With some changes I have in flight
GetFinalizerin compiler traceswent from "might be worth looking into making this faster" to "we spend
15% of compilation time here".
The answer to
HasFinalizeris cheap to cache and reduces the pressureon
GetFinalizersignificantly.