This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Emit interface generic dictionaries#3658
Merged
MichalStrehovsky merged 1 commit intodotnet:masterfrom May 20, 2017
Merged
Conversation
Generic interface types have a generic dictionary slot like any other type, except sometimes the slot is null. We can now call static methods on generic interfaces with a usable generic context. Got reminded of this while reading about the planned C# language support for static methods on interfaces. I didn't want to push on it when dotnet#3100 added the logic, but it turns out this is really easy.
| if (declType.IsInterface || declType.IsCanonicalSubtype(CanonicalFormKind.Any) || factory.LazyGenericsPolicy.UsesLazyGenerics(declType)) | ||
| if (declType.IsCanonicalSubtype(CanonicalFormKind.Any) | ||
| || factory.LazyGenericsPolicy.UsesLazyGenerics(declType) | ||
| || isInterfaceWithAnEmptySlot) |
Member
There was a problem hiding this comment.
We should probably find a way to skip adding a dictionary if it doesn't have any contents.
Member
Author
There was a problem hiding this comment.
That would be a general improvement we can also do for non-interface types - do you want me to do it in this pull request though?
Member
Author
There was a problem hiding this comment.
(Clarified offline - this is a topic for a future pull request.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic interface types have a generic dictionary slot like any other
type, except sometimes the slot is null.
We can now call static methods on generic interfaces with a usable
generic context.
Got reminded of this while reading about the planned C# language support
for static methods on interfaces. I didn't want to push on it when #3100
added the logic, but it turns out this is really easy.