This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Fix GVM analysis performance#3652
Merged
fadimounir merged 1 commit intodotnet:masterfrom May 18, 2017
Merged
Conversation
sergiy-k
reviewed
May 18, 2017
| { | ||
| _newDynamicDependenciesMayHaveAppeared = false; | ||
| foreach (DynamicDependencyNode dynamicNode in _markedNodesWithDynamicDependencies) | ||
| for(int i = 0; i < _markedNodesWithDynamicDependencies.Count; i++) |
Contributor
There was a problem hiding this comment.
Nit: missing space between 'for' and '('
Contributor
|
Thanks a lot! |
…y computed results (90% perf improvement on Release builds for the ASPNet benchmark app (22 mins to 2 mins total compile time)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the processing of dynamic dependencies to not recompute already computed results (90% perf improvement on Release builds for the ASPNet benchmark app (22 mins to 2 mins total compile time)