This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Verification of Endfinally (also Endfault) #3640
Merged
jkotas merged 6 commits intodotnet:masterfrom May 17, 2017
Dynatrace:EndFinally
Merged
Verification of Endfinally (also Endfault) #3640jkotas merged 6 commits intodotnet:masterfrom Dynatrace:EndFinally
jkotas merged 6 commits intodotnet:masterfrom
Dynatrace:EndFinally
Conversation
merge from dotnet/corert master
Merge dotnet/corert master
jkotas
reviewed
May 17, 2017
| { | ||
| MarkBasicBlock(_basicBlocks[r.ILRegion.HandlerOffset]); | ||
| } | ||
| MarkBasicBlock(_basicBlocks[_exceptionRegions[_currentBasicBlock.TryIndex.Value].ILRegion.HandlerOffset]); |
Member
There was a problem hiding this comment.
I think it should be done inside StartImportingBasicBlock. We want to verify finally or fault block even if there is no "leave".
Collaborator
Author
There was a problem hiding this comment.
Good point! We talked about it with @mmayr-at and it came up that this should be done somewhere else, but I wanted to go with the original code. Anyway... i will move it to StartImportingBasicBlock.
jkotas
approved these changes
May 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until this point we ignored the finally&fault blocks (that code was disabled). I also re-enabled that part, but this time without a for loop, since we can take advantage of the try and handler indexes directly on the BasicBlock