This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merged
Conversation
added 4 commits
May 17, 2017 11:10
CV has unique indexes and use them to link types inside, but somehow not-unique names create conflicts. Use mangled names to avoid them.
nattress
approved these changes
May 18, 2017
| { | ||
| System.Diagnostics.Debug.Assert(type.IsArray, "GetArrayTypeIndex was called with wrong type"); | ||
| ArrayType arrayType = (ArrayType)type; | ||
| ArrayTypeDescriptor arrayTypeDescriptor = new ArrayTypeDescriptor(); |
Contributor
There was a problem hiding this comment.
I think an object initializer reads nicer here:
ArrayTypeDescriptor arrayTypeDescriptor = new ArrayTypeDescriptor
{
ElementType = GetVariableTypeIndex(arrayType.ElementType, false);
Size = (uint)arrayType.GetElementSize().AsInt;
Rank = (uint)arrayType.Rank;
IsMultiDimensional = arrayType.IsMdArray? 1:0;
};
| arrayTypeDescriptor.Rank = (uint)arrayType.Rank; | ||
| arrayTypeDescriptor.IsMultiDimensional = arrayType.IsMdArray? 1:0; | ||
|
|
||
| ClassTypeDescriptor classDescriptor = new ClassTypeDescriptor(); |
Contributor
There was a problem hiding this comment.
Same here - object initializer :)
nattress
approved these changes
May 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeView ArrayType was added.
Also all names were changed to mangled names, as ProjectN does.