This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Remove the additional check from Math.Exp()#3533

Merged

jkotas merged 1 commit intodotnet:masterfrom

tijoytom-zz:master

May 5, 2017

Contributor

tijoytom-zz commented May 5, 2017

Math.Exp() to match dotnet/coreclr#4847.


          Remove the additional check from

e1797da

Math.Exp() to match dotnet/coreclr#4847.

dnfclas added the cla-already-signed label

tijoytom-zz changed the title ~~Remove the additional check from~~ Remove the additional check from Math.Exp()

Contributor Author

tijoytom-zz commented May 5, 2017

Here is the list that you pointed out
@tannergooding

Exp is doing additional checks (https://github.com/tijoytom/corert/blob/1fc641a152963474aa35ccc1ae760036bf01292b/src/System.Private.CoreLib/src/System/Math.cs#L248)
Abs(float) should be calling fabsf not fabs (https://github.com/tijoytom/corert/blob/1fc641a152963474aa35ccc1ae760036bf01292b/src/System.Private.CoreLib/src/System/Math.cs#L388). This could probably be done as part of the work to properly expose System.MathF.
Round is doing something other than copysign: https://github.com/tijoytom/corert/blob/1fc641a152963474aa35ccc1ae760036bf01292b/src/System.Private.CoreLib/src/System/Math.cs#L163. At first glance, it looks like it should be equivalent, but I didn't actually validate that it is correct for all the various edge cases.

For (3) i am hoping corefx tests whould notice the difference if any , i will check it as part of properly exposing MathF.

jkotas approved these changes

View reviewed changes

jkotas merged commit c80854a into dotnet:master

Member

tannergooding commented May 5, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-already-signed