Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Add full support for building with VS 2017#3436

Merged
jkotas merged 1 commit intodotnet:masterfrom
MichalStrehovsky:vs2017build
Apr 27, 2017
Merged

Add full support for building with VS 2017#3436
jkotas merged 1 commit intodotnet:masterfrom
MichalStrehovsky:vs2017build

Conversation

@MichalStrehovsky
Copy link
Member

This is a followup to #2390 that fixes a few things:

  • vs2017 no longer needs to be passed to build.cmd (it will be
    autodetected)
  • Building and running tests now works
  • Documentation updates to point out running from Developer Command
    prompt is needed.

Fixes #3394.

This is a followup to dotnet#2390 that fixes a few things:

* vs2017 no longer needs to be passed to build.cmd (it will be
autodetected)
* Building and running tests now works
* Documentation updates to point out running from Developer Command
prompt is needed.

Fixes dotnet#3394.
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit c40a975 into dotnet:master Apr 27, 2017
@MichalStrehovsky MichalStrehovsky deleted the vs2017build branch April 27, 2017 00:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual Studio 2015 (Community is free) is a pre-requisite to build this repository.

3 participants