This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Emit IMAGE_REL_BASED_RELPTR32 reloc in interface dispatch cells#3435
Merged
jkotas merged 2 commits intodotnet:masterfrom Apr 27, 2017
Merged
Emit IMAGE_REL_BASED_RELPTR32 reloc in interface dispatch cells#3435jkotas merged 2 commits intodotnet:masterfrom
jkotas merged 2 commits intodotnet:masterfrom
Conversation
We have means how to emit the reloc in the object writer now. Also, fix a bug where `CompilationGroup.ContainsType` was used instead of `ISymbolNode.RepresentsIndirectionCell` to determine if an indirection is needed. The distinction doesn't matter for the UTC-based compiler, but it does in the CoreRT compiler. Fixes dotnet#2542.
Member
Author
|
@nattress PTAL. I needed to do something small to unwind from the metadata work... |
jkotas
approved these changes
Apr 26, 2017
nattress
approved these changes
Apr 26, 2017
|
|
||
| if (factory.Target.Abi == TargetAbi.CoreRT) | ||
| IEETypeNode interfaceType = factory.NecessaryTypeSymbol(_targetMethod.OwningType); | ||
| if (!interfaceType.RepresentsIndirectionCell) |
Contributor
There was a problem hiding this comment.
Nit: Reads easier to just do the positive case first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have means to emit the reloc in the object writer now.
Also, fix a bug where
CompilationGroup.ContainsTypewas used insteadof
ISymbolNode.RepresentsIndirectionCellto determine if anindirection is needed. The distinction doesn't matter for the UTC-based
compiler, but it does in the CoreRT compiler.
Fixes #2542.