This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merged
Conversation
Change Description:
For Pinvoke function, Currently Mcg will try to resolve its 'real' native exported function name through lib file. This add a hard dependency on Lib files to allow pinvoke works correctly
If one of its lib file doesn't exists,
if UseDefaultPInvoke is set, then the app may fail to launch
if UseDefaultPInvoke isn't set, then throw exception if someone try to call this function during runtime.
The change will to use LoadLibrary/GetProcAddress to fetch native function during runtime when passing IFS:UseLoadLibraryForPInvoke to ilc.
Also since it isn't clear whether Windows will allow to use LoadLibrary/GetProcAddress in UWP, so add LoadLibrary/GetProcAddress support code into Mcg Code template
Changes:
1. Move McgGeneratedNativeCallCodeAttribute from S.P.Interop to S.P.Corelib
The LoadLibray/GetProcAddress support itself need to call some pinvokes(CoTaskMemAlloc/CoTaskMemFree), thus Mcg should skip these these pinvokes(CoTaskMemAlloc/CoTaskMemFree).
2. Add IFS:UseLoadLibraryForPInvoke to enable LoadLibrary Support. By default, don't use LoadLibrary
3. Add EntryPointNotFoundException and DllNotFoundException as wellknown type, since mcg generated code depends on these two types
Remaining:
1. Stdcall convention support for missing lib case
[tfs-changeset: 1655835]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.