This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Move DllNotFoundException, EntryPointNotFoundException to CoreLib#3415
Merged
jkotas merged 1 commit intodotnet:masterfrom Apr 26, 2017
Merged
Move DllNotFoundException, EntryPointNotFoundException to CoreLib#3415jkotas merged 1 commit intodotnet:masterfrom
jkotas merged 1 commit intodotnet:masterfrom
Conversation
Member
|
You need to add forwarders for these to https://github.com/dotnet/corert/blob/master/src/System.Private.Interop/src/TypeForwarders.cs for now. They can be removed once the change propagates through the system. |
Member
| { | ||
| // TODO: should be DllNotFoundException, but layering... | ||
| throw new TypeLoadException(moduleName); | ||
| throw new DllNotFoundException(string.Format(SR.Arg_DllNotFoundExceptionParameterized, moduleName)); |
Member
There was a problem hiding this comment.
This should call SR.Format.
Contributor
Author
|
@jkotas Done @MichalStrehovsky I will keep the issue open and move more exceptions or attributes as necessary. |
| </data> | ||
| <data name="PlatformNotSupported_StrongNameSigning" xml:space="preserve"> | ||
| <value>Strong-name signing is not supported on this platform.</value> | ||
|
|
Member
There was a problem hiding this comment.
Inadvertent white space change?
Contributor
Author
There was a problem hiding this comment.
Yes sorry I was trying to merge a conflict from github UI. I will do the merge from my console and rebase.
jkotas
approved these changes
Apr 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3231
@MichalStrehovsky PTAL