This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Fix #3211: Node ILCompiler.DependencyAnalysis.GCStaticsNode is not ma…#3227
Merged
fadimounir merged 1 commit intodotnet:masterfrom Apr 6, 2017
Merged
Fix #3211: Node ILCompiler.DependencyAnalysis.GCStaticsNode is not ma…#3227fadimounir merged 1 commit intodotnet:masterfrom
fadimounir merged 1 commit intodotnet:masterfrom
Conversation
Author
|
@MichalStrehovsky Please take a look |
MichalStrehovsky
approved these changes
Apr 5, 2017
|
|
||
| private static void TestUnconstructedTypes() | ||
| { | ||
| var a = typeof(UnconstructedTypeInstantiator<UnconstructedTypeWithGCStatics>).ToString(); |
Member
There was a problem hiding this comment.
Maybe add a comment that this is testing for compilation failures due to references to unused static bases with a link to the github issue?
Author
|
Fixes #3211 |
…not marked when ILCompiler.DependencyAnalysis.RyuJitNodeFactory is MarkingComplete
Contributor
|
@fadimounir many thanks for so quick fix. My question is when it will be merged because our work is blocked by this issue. |
Author
|
@sergign60 The fix is now merged :) Let me know if you encounter any other related issue. I'll gladly take a look. |
Contributor
|
@fadimounir thanks for this very fast merging. I've opened another issue #3248 I guess it is a little more difficult :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rked when ILCompiler.DependencyAnalysis.RyuJitNodeFactory is MarkingComplete