Add mangled names for delegate and struct marshalling stubs#3220
Add mangled names for delegate and struct marshalling stubs#3220shrah merged 1 commit intodotnet:masterfrom
Conversation
|
@MichalStrehovsky PTAL |
|
@dotnet-bot test OSX Release |
|
@dotnet-bot test OSX Debug and CoreCLR tests |
| { | ||
| get | ||
| { | ||
| if (ThunkType == StructMarshallingThunkType.ManagedToNative) |
There was a problem hiding this comment.
A switch statement would be safer here. If we add more thunk types in the future, they'll fall into the Cleanup category silently.
MichalStrehovsky
left a comment
There was a problem hiding this comment.
The name of the interfaces became a bit weird (a method is now a "prefix-mangled type"?), but I don't really have any better name suggestions. If you could come up with a more fitting name, it would be great, but I'm not going to block on that.
|
I admit, the interface names have become a little confusing. I don't have any better name suggestions either. I can think of IPrefixMangledTypeContainer/ IPrefixMangledMethodContainer, but I am not sure whether that is any better. I will leave it as it is for now. |
|
@dotnet-bot test OSX Release |
You should at lease update the comments on the interfaces then. With your change, the comments are outdated. |
Michal added concept of prefix mangled type/method couple of days ago which enables us to add managled name for delegate and struct marshalling stubs.
|
This PR builds and passes basic tests on my Mac so we can probably just merge. |
Michal added concept of prefix mangled type/method couples of
days ago which enables us to add managled name for delegate and struct
marshalling stubs.