This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Add type loader support for building arrays of pointers#3209
Merged
MichalStrehovsky merged 2 commits intodotnet:masterfrom Apr 7, 2017
Merged
Add type loader support for building arrays of pointers#3209MichalStrehovsky merged 2 commits intodotnet:masterfrom
MichalStrehovsky merged 2 commits intodotnet:masterfrom
Conversation
This will be taking similar code paths as multidimensional arrays - the arrays of pointers don't have anything "interesting" in the EEType and should mostly just pass through. Checking this in as disabled for PROJECTN since NUTC will blow up if it sees an array of pointers.
Member
Author
|
@davidwrighton PTAL |
davidwrighton
suggested changes
Apr 5, 2017
Member
davidwrighton
left a comment
There was a problem hiding this comment.
See if you can use the mdarray template...
| #if !PROJECTN | ||
| else if (type.IsSzArray && ((ArrayType)type).ElementType.IsPointer) | ||
| { | ||
| pTemplateEEType = typeof(void*[]).TypeHandle.ToEETypePtr(); |
Member
There was a problem hiding this comment.
I think that you could simply have this use the same template as the multidimensional array path, and then we wouldn't need all the #if !PROJECTN bits.
Member
Author
There was a problem hiding this comment.
Yup, works fine that way.
Member
Author
|
@dotnet-bot Test OSX Debug and CoreCLR tests |
davidwrighton
approved these changes
Apr 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be taking similar code paths as multidimensional arrays - the
arrays of pointers don't have anything "interesting" in the EEType and
should mostly just pass through.
Checking this in as disabled for PROJECTN since NUTC will blow up if it
sees an array of pointers.