This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Change the mangled names to use Utf8String #2200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce Utf8String and Utf8StringBuilder types - Change some of the name mangling to use these types - Change ISymbolNode.Mangled property to AppendMangledName method that takes Utf8StringBuilder to append the mangled name to, and NameMangler object to use - Switch implementation of number of simple properties to the more compact declarative syntax This change reduces amount of GC allocations in the compiler and creates opportunities for further reductions. E.g. Total GC heap allocs for the Simple/Reflection test goes from 366 MB to 310 MB. It does not make anything measurably faster though.
Member
Author
|
@MichalStrehovsky PTLA |
MichalStrehovsky
approved these changes
Nov 15, 2016
Member
MichalStrehovsky
left a comment
There was a problem hiding this comment.
LGTM! I like where this is going!
Member
Author
|
@dotnet-bot test this please |
1 similar comment
Member
Author
|
@dotnet-bot test this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces amount of GC allocations in the compiler and creates opportunities for further reductions. E.g. Total GC heap allocs for the Simple/Reflection test goes from 366 MB to 310 MB. It does not make anything measurably faster though.
Part of #2178