Skip to content
This repository was archived by the owner on Aug 2, 2023. It is now read-only.

.NET Core 3.1 Preview2 IntelliSense (English)#2758

Merged
carlossanlop merged 2 commits intodotnet:IntellisensePackagefrom
carlossanlop:IntellisensePackage
Oct 22, 2019
Merged

.NET Core 3.1 Preview2 IntelliSense (English)#2758
carlossanlop merged 2 commits intodotnet:IntellisensePackagefrom
carlossanlop:IntellisensePackage

Conversation

@carlossanlop
Copy link

@carlossanlop carlossanlop commented Oct 21, 2019

@ahsonkhan @safern please review.

Explanation:

  • Here is the actual PR that bumps the IntelliSense in corefx 3.1 using the nupkg file uploaded to the blob (the PR that matters).
  • This PR's purpose is to simply keep a change history for our IntelliSense files, so people can know what is included in the nupkg from the other PR.
  • Eventually this branch will go away and we will automate the process. There won't be a need to do this.

CC @mairaw

@carlossanlop
Copy link
Author

@ahson should I have named this nupkg "Preview1", since we are already one version behind?

@ahsonkhan
Copy link
Contributor

@ahson should I have named this nupkg "Preview1", since we are already one version behind?

Yes please. Also, you tagged the wrong person :p

Copy link
Contributor

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than version change, looks good.

@@ -543,7 +543,7 @@ The current <paramref name="reader" /> token does not start or represent a value
<param name="utf8Text">The UTF-8 encoded text to compare against.</param>
<returns>
<see langword="true" /> if the string value of this element has the same UTF-8 encoding as
<paramref name="utf8Text" />; otherwise, <see langword="false" />.</returns>
<paramref name="utf8Text" />; otherwise, <see langword="false" />.</returns>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spacing change is weird. Where did it come from.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloaded from Docs. I don't touch the files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unexpected endline may have been ported like that with the docs porting tool some time ago, because some programmers tend to write their triple slash comments with lines that are no longer than 80 characters. It used to be a restriction in older languages, but not on C#, so I guess people still do it to reduce the need to scroll horizontally.

The docs porting tool used to port these messages untouched, but I fixed that bug some time ago: any unexpected endline that is not preceded by a symbol (.,?!*:) is removed automatically before porting.

So maybe this unexpected endline is a remnant of how the docs porting tool used to port strings before I fixed that.

I wouldn't worry. I noticed there are a lot of these, and some of these precede the docs porting tool.

@carlossanlop carlossanlop merged commit 2bcc946 into dotnet:IntellisensePackage Oct 22, 2019
@carlossanlop carlossanlop deleted the IntellisensePackage branch October 22, 2019 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants