This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Add a code analyzer to fix certain Memory<T> usage#2236
Merged
ahsonkhan merged 2 commits intodotnet:masterfrom May 1, 2018
Merged
Add a code analyzer to fix certain Memory<T> usage#2236ahsonkhan merged 2 commits intodotnet:masterfrom
ahsonkhan merged 2 commits intodotnet:masterfrom
Conversation
Member
|
Would it be possible to write a analyzer that detects when there are multiple unnecessary calls to Memory.Span in a single method body? |
Contributor
Author
I believe so, but it would be significantly more complex and require semantic tracking and analysis. Feel free to file an issue for it. I am assuming it would only highlight the issue, since offering a fix in that case seems futile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2215
Swap the order of
Memory<T>.Slice(start, length).Spanto beMemory<T>.Span.Slice(start, length)Screenshots:
Majority of the code here is template code. Focus on the following files:
corefxlab fix - #2237
cc @dotnet/corefxlab-contrib, @khellang, @VSadov, @KrzysztofCwalina, @terrajobst