This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Split packaging for Clrcompression by appx/non-appx#7009
Closed
ianhays wants to merge 2 commits intodotnet:masterfrom
ianhays:packagingfix
Closed
Split packaging for Clrcompression by appx/non-appx#7009ianhays wants to merge 2 commits intodotnet:masterfrom ianhays:packagingfix
ianhays wants to merge 2 commits intodotnet:masterfrom
ianhays:packagingfix
Conversation
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <File Include="$(WinNativePath)ProjectK\Runtime\clrcompression.dll"> |
Member
There was a problem hiding this comment.
You should remove "ProjectK\Runtime" from this now. Please do verify that in TFS builds.
Contributor
|
LGTM after Wes's comments |
Contributor
Author
|
Huh, can't merge on mobile until the ci finishes. Well this should be good to to, I modeled the paths after what sni did (i.e. winnativepath in tfs goes to projects/native/). The binaries directory wasn't working when I tested it, but I can't see why. It was linking it to "bin/corefx/open' instead of "projects/runtime/" |
Contributor
|
This needs to be rebased, but I can't push to Ian's remote, so I'll just put up a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@weshaggard @ericstj