This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Cross-compilation support for native code#6194
Closed
manu-st wants to merge 1 commit intodotnet:masterfrom
Closed
Conversation
Member
|
@jkotas, I believe you reviewed a similar change for coreclr and corert... would you mind taking a peek at this one, too? |
| # Disable the native build when targeting Windows. | ||
|
|
||
| if [ "$__BuildOS" != "$__HostOS" ]; then | ||
| if [ "$__BuildOS" != "$__HostOS" ] && [ $__CrossBuild == 0 ]; then |
Member
There was a problem hiding this comment.
I'm confused by this part. We warn that cross-compilation isn't yet supported if CrossBuild isn't set, but if it is set, we don't warn?
Author
There was a problem hiding this comment.
Rereading it again, I think that I should have left things as they are for the condition, but changed the warning message to be more explicit. It should say something along the lines of:
echo "Warning: compiling native components for a different OS is not yet supported"
Would you agree?
Member
|
Thanks, @manu-silicon. Replaced by #6585. |
This was referenced Mar 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for compiling the native code via cross compilation.
It uses almost the same setup as CoreCLR/CoreRT.