Conversation
Support for passing ALPN application protocol list to SChannel and querying for the negotiated protocol post handshake on client and server.
|
cc: @bartonjs, @vijaykota, @CIPop, @davidsh |
|
@dotnet-bot test this please (https://github.com/dotnet/corefx/issues/4688) |
There was a problem hiding this comment.
I assume this is just a temporary stub until the functionality is actually implemented on Unix? is there an issue tracking it?
There was a problem hiding this comment.
Yes. So do I assume correctly I just create a separate issue for Unix which could be implemented later ?
There was a problem hiding this comment.
Ideally we'd implement it at the same time. If that's not possible, then yes, opening an issue to track the Unix implementation, and including a TODO comment here citing that issue number. Then there's a question of what the temporary behavior here should be. I've not yet seen how this is consumed, but often the right behavior is "throw new PlatformNotSupportedException();"... but it depends on the usage.
|
Thx for the contribution. I think there is already an open GitHub issue for ALPN support. But this PR will not be able to reviewed or merged until after the API review process is used. |
|
See #2928 |
|
#2928 has up for grabs tag. |
|
@jasonwilliams200OK Yes, #2928 is 'up for grabs'. As part of solving that, new methods/properties will need to be added to the public API surface for SslStream. We have a separate process for APi review so we'll want to use that first to discuss/refine the new APIs and we'll want to consider how this API change affects the Desktop SslStream class as well. API Review Process: |
|
API Review ticket created: #4721 |
Support for passing ALPN application protocol list to SChannel
and querying for the negotiated protocol post handshake on client
and server.