This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Remove the use of dotnet-core#43100
Closed
mmitche wants to merge 1 commit intodotnet:release/3.1from
Closed
[release/3.1] Remove the use of dotnet-core#43100mmitche wants to merge 1 commit intodotnet:release/3.1from
mmitche wants to merge 1 commit intodotnet:release/3.1from
Conversation
Anipik
approved these changes
Aug 13, 2021
Member
|
FWIW I can repro locally the issue reported by the CI: (I am trying to backport dotnet/runtime#57479 to 3.1 and can't build corefx) |
Member
|
The error no longer occurs, I can build the repo using the changes from this PR |
Member
|
@mmitche what's the status of this, should we merge? |
Member
Author
It would be good to, but there needs to be investigation of the error. I assume it would break the official build. |
|
@mmitche friendly ping in case you think we should take this change for the next servicing release. Deadline is Monday 03/14 (I'm assuming the same deadline applies to infra changes). |
Member
Author
|
@carlossanlop Yeah we should take this for this servicing release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.