This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Add CentOS 9 RID and make CentOS 8 arm64 as well#43068
Merged
Anipik merged 1 commit intodotnet:release/3.1from May 5, 2021
Merged
[release/3.1] Add CentOS 9 RID and make CentOS 8 arm64 as well#43068Anipik merged 1 commit intodotnet:release/3.1from
Anipik merged 1 commit intodotnet:release/3.1from
Conversation
Member
|
If this is to be serviced, please add the usual template. |
Member
Author
Okay. I copied the template from another PR in this repo. If it's not right, can you help me find the canonical template? |
Member
|
Looks great to me. @wfurt are you the right person to evaluate this one? |
wfurt
approved these changes
Apr 27, 2021
Member
wfurt
left a comment
There was a problem hiding this comment.
LGTM.
It seems like are trying to keep RID graph same across releases and this matches main branch.
Anipik
reviewed
Apr 28, 2021
| "3.1.6", | ||
| "3.1.7" | ||
| ], | ||
| "BaselineVersion": "3.1.5", |
There was a problem hiding this comment.
Can you update the baseline version to 3.1.7 as well
This is the only part of dotnet/runtime#34088 that wasn't already backported to release/3.1. https://www.redhat.com/en/blog/faq-centos-stream-updates says: > There will not be a CentOS Linux 9. > > CentOS Stream 9 will launch in Q2 2021 as part of the RHEL 9 > development process. The last part also means that the current parent-child relationship that we use for RHEL->CentOS in our RID graph will flip starting in 9. I dont see any immediate impact, so I think we can leave it alone for now. I got a (currently internal) build of CentOS Stream 9 and /etc/os-release looks like this: $ cat /etc/os-release NAME="CentOS Stream" VERSION="9" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="9" PLATFORM_ID="platform:el9" PRETTY_NAME="CentOS Stream 9" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:9" HOME_URL="https://centos.org/" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux 9" REDHAT_SUPPORT_PRODUCT_VERSION="CentOS Stream"
99ce8c8 to
07c5ddb
Compare
Anipik
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port Description
This is the only part of dotnet/runtime#34088 that wasn't already backported to release/3.1.
https://www.redhat.com/en/blog/faq-centos-stream-updates says:
That's my motivation: I want to be able to build .NET Core 3.1 for RHEL 9
The last part also means that the current parent-child relationship that we use for RHEL->CentOS in our RID graph will flip starting in 9. I dont see any immediate impact, so I think we can leave it alone for now.
I got a (currently internal) build of CentOS Stream 9 and
/etc/os-releaselooks like this:I have been told that builds of CentOS Stream 9 should become public soon. I don't know exactly when, though.
Customer Impact
This (kind of) blocks Red Hat from building .NET Core 3.1 on RHEL 9: we can apply this patch locally, but it's probably better for everyone if it's here upstream too.
Regression
This is not a regression.
Testing
I have tested that this RID update fixes the build issue for me.
Risk
The risk of this is pretty low: it's just adding RIDs.