Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/3.1] Add Fedora 34 RID#42975

Merged
Anipik merged 1 commit intodotnet:release/3.1from
omajid:3.1-fedora-34-rid
Sep 10, 2020
Merged

[release/3.1] Add Fedora 34 RID#42975
Anipik merged 1 commit intodotnet:release/3.1from
omajid:3.1-fedora-34-rid

Conversation

@omajid
Copy link
Member

@omajid omajid commented Aug 20, 2020

Fedora 34 is currently in development. Building .NET Core 3.1 there (via source-build) fails because the runtime id fedora.34 is unknown:

error NETSDK1083: The specified RuntimeIdentifier 'fedora.34-x64' is not recognized.

Full log is here: https://kojipkgs.fedoraproject.org//work/tasks/7435/49647435/build.log

This is a partial backport of dotnet/runtime#34088

Fedora 34 is currently in development. Building .NET Core 3.1 there (via
source-build) fails because the runtime id `fedora.34` is unknown:

    error NETSDK1083: The specified RuntimeIdentifier 'fedora.34-x64' is not recognized.

This is a partial backport of
dotnet/runtime#34088
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it will go to the September release with #42968, we may need to also update platform package version.

@Anipik Anipik added the Servicing-consider Issue for next servicing release review label Aug 21, 2020
@Anipik Anipik added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 21, 2020
@danmoseley
Copy link
Member

@wfurt @Anipik RID updates are normally "tell mode" and don't need "servicing-consider"

I assume we'll merge this in a couple weeks to go out in October, and that's why you marked no merge @Anipik ?

Do we need this for 2.1?

@Anipik
Copy link

Anipik commented Aug 25, 2020

I assume we'll merge this in a couple weeks to go out in October, and that's why you marked no merge @Anipik ?

i added servicing consider to check if we want to take it in the September release. You are correct, i added no merge so we dont merge it for September release before asking tactics as we were late in the cycle.

@omajid
Copy link
Member Author

omajid commented Aug 25, 2020

Do we need this for 2.1?

IMO, that would be more of a nice-to-have, compared to this which is a must-have from my point of view.

@omajid omajid changed the title Add Fedora 34 RID [release/3.1] Add Fedora 34 RID Aug 25, 2020
@wfurt
Copy link
Member

wfurt commented Aug 25, 2020

I was on assumption we try to keep the rid graph same on all releases...?

@danmoseley
Copy link
Member

Hmm, I think we service the RID graph whenever needed to include support for distros we support for that past release. I am not sure of the exact policy for when we add support for new distros, but we do do it when it would otherwise mean that there was not a supported version of the distro. In this case 3.1 is documented to support Fedora 30+.

@leecow @ericstj can you remind of the exact policy for adding distro version support to released versions, and whether the RID changes mirror those?

@danmoseley danmoseley removed the Servicing-consider Issue for next servicing release review label Sep 1, 2020
@danmoseley
Copy link
Member

I think @leecow is back in a week.

@ericstj
Copy link
Member

ericstj commented Sep 1, 2020

I believe for our LTS release we do tell-mode-servicing for RIDs that should be supported by those (EG: new versions that are compatible with existing builds). We don't service brand new distros that were never supported by the release.

@danmoseley
Copy link
Member

Thanks, I believe we have time to also get Lee's confirmation before servicing window closes.

@leecow
Copy link
Member

leecow commented Sep 10, 2020

Yep, let's get this in for October.

@Anipik Anipik merged commit fe18c49 into dotnet:release/3.1 Sep 10, 2020
@rbhanda
Copy link

rbhanda commented Jan 26, 2021

dotnet/core#5851

@wfurt wfurt mentioned this pull request Feb 16, 2021
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants