This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Fix HTTP Digest authentication#42877
Merged
Anipik merged 1 commit intodotnet:release/3.1from Mar 25, 2020
Merged
Conversation
…g, the qop value is read to incorporate the correct hash algorithm for the digest challenge. Also adjusted the conditional in the challenge parse function to allow the opaque value to be an empty string
Member
|
@davidsh is this good to get "servicing-consider" label? |
Contributor
Yes. |
Member
|
Ok done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of dotnet/runtime#32983. Original issue: dotnet/runtime#32943
Description
This bug was found in testing http requests with a Bosch IP Camera that supports the ONVIF protocol. Bosch is a large manufacturer in the realm of ONVIF compliant cameras. A Bosch camera that was being tested sent a digest challenge with the opaque value as an empty-string. The current dotnet core library fails to use the correct digest scheme because it breaks on parsing the empty string.
Customer Impact
Without this fix, customers can not communicate with the Bosch IP Cameras which use HTTP Digest communications.
Regression?
No
Packaging reviewed?
Change needed to System.Net.Http.dll which is part of the shared framework Microsoft.NETCore.App package.
Risk
Low, covered by unit tests