This repository was archived by the owner on Jan 23, 2023. It is now read-only.
3.1: make sure we have big enough buffer to prevent endless spin while dumping route table on OSX#42800
Merged
Anipik merged 1 commit intodotnet:release/3.1from Jan 14, 2020
Merged
Conversation
stephentoub
approved these changes
Jan 7, 2020
Member
|
Approved for March. |
Member
|
Moved back to 3.1.2 per tactics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is port of dotnet/runtime#591 to address
dotnet core 3 on macOS Catalina: NetworkInterface causes high CPU#42634. Existing code assumes that when provided buffer is too small,sysctl()will update provided length. However that is happening only when NULL is passed in and we will en dup in endless spin trying to re-allocate to same size.Impact
This is race condition impacting OSX only. However, when it happens, we spin in native PAL code and there is no recovery or workaround.
Regression?
No.
Risk
Small. Fix is in OSX pal code and does not impact other platforms. Fix was verified by impacted customer.
fixes #42634