This repository was archived by the owner on Jan 23, 2023. It is now read-only.
System.Native: Add deployment target version for OSX#42412
Merged
stephentoub merged 1 commit intodotnet:masterfrom Nov 6, 2019
Merged
System.Native: Add deployment target version for OSX#42412stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
As noticed in dotnet#42408 we don't pass any minimum OSX target version to CMake. This means it falls back to the host version, e.g. if you build on Mojave it would pass `-mmacosx-version-min=10.14` to the compiler. .NET Core's minimum supported OSX version is 10.13 so pass that to CMake.
ViktorHofer
approved these changes
Nov 6, 2019
filipnavara
approved these changes
Nov 6, 2019
safern
approved these changes
Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noticed in #42408 we don't pass any minimum OSX target version to CMake.
This means it falls back to the host version, e.g. if you build on Mojave it would pass
-mmacosx-version-min=10.14to the compiler..NET Core's minimum supported OSX version is 10.13 so pass that to CMake.