This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add support for NumericString to X500DistinguishedName#38766
Merged
bartonjs merged 3 commits intodotnet:masterfrom Jun 22, 2019
Merged
Add support for NumericString to X500DistinguishedName#38766bartonjs merged 3 commits intodotnet:masterfrom
bartonjs merged 3 commits intodotnet:masterfrom
Conversation
An X500DN which contains a valid NumericString will now not cause the entire string to turn into the empty string; which (per the tests) matches the Windows/NetFX behavior.
krwq
approved these changes
Jun 22, 2019
krwq
reviewed
Jun 22, 2019
src/Common/src/System/Security/Cryptography/Asn1Reader/AsnCharacterStringEncodings.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An X500DN which contains a valid NumericString will now not cause the
entire string to turn into the empty string; which (per the tests) matches the
Windows/NetFX behavior.
Fixes #38014.