Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/2.1] Enable Tizen CI#31698

Merged
danmoseley merged 5 commits intodotnet:release/2.1from
gbalykov:tizen-ci
Oct 30, 2018
Merged

[release/2.1] Enable Tizen CI#31698
danmoseley merged 5 commits intodotnet:release/2.1from
gbalykov:tizen-ci

Conversation

@gbalykov
Copy link
Member

@gbalykov gbalykov commented Aug 10, 2018

@karelz karelz added this to the 2.1.x milestone Aug 23, 2018
@wtgodbe
Copy link
Member

wtgodbe commented Aug 23, 2018

@dotnet-bot test CI please

@wtgodbe
Copy link
Member

wtgodbe commented Aug 23, 2018

@dotnet-bot test Linux x64 Release Build

@wtgodbe
Copy link
Member

wtgodbe commented Aug 23, 2018

@gbalykov Is there anything else you need to do here before we think about merging?

@gbalykov
Copy link
Member Author

gbalykov commented Aug 24, 2018

@wtgodbe we need to wait for dotnet/coreclr#19058 to get to sdk first, because build with tizen.5.0.0 RID doesn't work yet

@karelz karelz added the blocked Issue/PR is blocked on something - see comments label Sep 5, 2018
@wtgodbe
Copy link
Member

wtgodbe commented Sep 19, 2018

@gbalykov any update?

@gbalykov
Copy link
Member Author

gbalykov commented Sep 20, 2018

@wtgodbe release/2.1 Tizen builds should work now, but master builds do not work yet, this is work in progress

gbalykov and others added 5 commits October 3, 2018 13:35
@gbalykov
Revert "Disable Tizen CI runs"
d939c8f 
This reverts commit 37774fd.
@gbalykov
Update Tizen CI docker image
a6ef8e2
@gbalykov
Update links required for generation of Tizen rootfs
8fb2d86
@JongHeonChoi @gbalykov
Update Tizen CI docker image (tizen-rootfs-5.0m1) (dotnet#30480)
72e0e2a 
* Update arm32_ci_script.sh

* Update arm32_ci_script.sh

* Update arm32_ci_script.sh
@gbalykov
Update Tizen CI RID (dotnet#30692)
5bacdb4 
* Update Tizen RID for CI

* Update Tizen url for rootfs generation
@gbalykov gbalykov changed the title [WIP][release/2.1] Enable Tizen CI [release/2.1] Enable Tizen CI Oct 3, 2018
@gbalykov
Copy link
Member Author

gbalykov commented Oct 3, 2018

@dotnet-bot test ci please

@gbalykov
Copy link
Member Author

gbalykov commented Oct 3, 2018

@dotnet-bot test OSX x64 Debug Build
@dotnet-bot test Windows x86 Release Build

@gbalykov
Copy link
Member Author

gbalykov commented Oct 8, 2018

@dotnet-bot test ci please

@stephentoub
Copy link
Member

stephentoub commented Oct 16, 2018

@gbalykov, is this still blocked? From your comment almost a month ago it sounds like this can now be merged?

@gbalykov
Copy link
Member Author

gbalykov commented Oct 16, 2018

@stephentoub this should work now, but I was not able to test Tizen CI on this PR, as test ci please doesn't seem to regenerate ci jobs. Could you, please, try test ci please?

@stephentoub stephentoub reopened this Oct 16, 2018
@stephentoub
Copy link
Member

stephentoub commented Oct 16, 2018

@dotnet-bot test ci please

@gbalykov
Copy link
Member Author

gbalykov commented Oct 16, 2018

@stephentoub tizen jobs are not regenerated, do you know what could be the reason of this?

@stephentoub
Copy link
Member

stephentoub commented Oct 16, 2018

tizen jobs are not regenerated, do you know what could be the reason of this?

@mmitche? Do we not regenerate jobs as part of part of asking to test ci please? I remember that used to be the case, and you had to actually merge and then subsequent PRs would pick it up, but I thought that changed. No?

@mmitche
Copy link
Member

mmitche commented Oct 16, 2018

@stephentoub It still only generates disabled jobs for verification, it does not do anything to the jobs on this PR. That will change as we move to Azure DevOps.

@gbalykov
Copy link
Member Author

gbalykov commented Oct 16, 2018

@stephentoub for some reason Gen CI(dotnet-ci) - release/2.1/netci.groovy has started just few minutes ago, and looks like it has generated tizen jobs

@gbalykov
Copy link
Member Author

gbalykov commented Oct 16, 2018

@dotnet-bot test Tizen armel Release Build

@stephentoub
Copy link
Member

stephentoub commented Oct 16, 2018

@dotnet-bot test OSX x64 Debug Build please

2 similar comments
@gbalykov
Copy link
Member Author

gbalykov commented Oct 23, 2018

@dotnet-bot test OSX x64 Debug Build please

@gbalykov
Copy link
Member Author

gbalykov commented Oct 26, 2018

@dotnet-bot test OSX x64 Debug Build please

@gbalykov
Copy link
Member Author

gbalykov commented Oct 26, 2018

@stephentoub CI testing has fully passed

@stephentoub
Copy link
Member

stephentoub commented Oct 26, 2018

@danmosemsft, can this be merged? (release/2.1)

@danmoseley danmoseley added the Servicing-consider Issue for next servicing release review label Oct 26, 2018
@danmoseley danmoseley merged commit 8b52a2e into dotnet:release/2.1 Oct 30, 2018
@danmoseley
Copy link
Member

danmoseley commented Oct 30, 2018

Merged to match dotnet/coreclr#19410 per discussion.

@stephentoub stephentoub removed the blocked Issue/PR is blocked on something - see comments label Oct 30, 2018
@vivmishra vivmishra added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 30, 2018
@vivmishra
Copy link

vivmishra commented Oct 30, 2018

Approved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@weshaggard weshaggard

@wtgodbe wtgodbe

@gbalykov gbalykov

Labels

area-Tizen Servicing-approved Approved for servicing release

Projects

None yet

Milestone

2.1.x

Development

Successfully merging this pull request may close these issues.

10 participants

@gbalykov @wtgodbe @stephentoub @mmitche @danmoseley @vivmishra @joshfree @karelz @weshaggard @JongHeonChoi