Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/2.1] Port Tizen missing rids to release/2.1#30640

Merged
danmoseley merged 1 commit intodotnet:release/2.1from
gbalykov:port-tizen-missing-rids-to-2.1
Jul 5, 2018
Merged

[release/2.1] Port Tizen missing rids to release/2.1#30640
danmoseley merged 1 commit intodotnet:release/2.1from
gbalykov:port-tizen-missing-rids-to-2.1

Conversation

@gbalykov
Copy link
Member

@stephentoub stephentoub changed the title Port Tizen missing rids to release/2.1 [release/2.1] Port Tizen missing rids to release/2.1 Jun 25, 2018
@stephentoub stephentoub added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 25, 2018
@stephentoub
Copy link
Member

cc: @danmosemsft

@danmoseley
Copy link
Member

This needs to go to shiproom. @weshaggard are you the right person to write that up?

@weshaggard
Copy link
Member

@danmosemsft I don't have any context here. The change looks good to me but I'm not sure who the sponsor should be.

@gbalykov
Copy link
Member Author

@weshaggard could you, please, share the approximate date, when this could be merged?

@gbalykov
Copy link
Member Author

gbalykov commented Jul 5, 2018

cc @jkotas @Petermarcu
This is required for build for Tizen 5.0.0, original PR #29684

@jkotas
Copy link
Member

jkotas commented Jul 5, 2018

@gbalykov Could you please answer a few questions about this fix:

These are the kind of questions that the shiproom asks. I would like to get the answers from you to make sure they are accurate. Thanks.

@gbalykov
Copy link
Member Author

gbalykov commented Jul 5, 2018

@jkotas

  1. This change allows to build CoreFX with Tizen 5.0 and Tizen x86 RIDs both on master and release/2.1 branches (master branch downloads https://www.nuget.org/packages/Microsoft.NETCore.Platforms, https://www.nuget.org/packages/Microsoft.NETCore.App/, etc., which currently don't contain Tizen 5.0 RIDs)
  2. Currently, we don't see workarounds for this

@danmoseley danmoseley removed the request for review from ericstj July 5, 2018 18:44
@danmoseley
Copy link
Member

Approved

@danmoseley danmoseley merged commit 8f71a67 into dotnet:release/2.1 Jul 5, 2018
@jkotas
Copy link
Member

jkotas commented Jul 5, 2018

@weshaggard @danmosemsft Thank you for getting this approved

@weshaggard
Copy link
Member

@wtgodbe this is going to require that we bump the version of Microsoft.NETCore.Platforms and add it to the list of packages we are shipping. Can you please go ahead and do that?

@weshaggard weshaggard removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 5, 2018
@wtgodbe
Copy link
Member

wtgodbe commented Jul 5, 2018

@weshaggard sure thing

@wtgodbe
Copy link
Member

wtgodbe commented Jul 5, 2018

#30854

@karelz
Copy link
Member

karelz commented Jul 8, 2018

Adding approved tag based on @danmosemsft approval above: #30640 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants