This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add the Globalization Invariant mode tests#17798
Merged
tarekgh merged 4 commits intodotnet:masterfrom Apr 3, 2017
Merged
Conversation
Member
Author
|
CC @stephentoub @danmosemsft @weshaggard @krwq |
danmoseley
reviewed
Apr 2, 2017
|
|
||
| [Theory] | ||
| [MemberData(nameof(IsPrefix_TestData))] | ||
|
|
Member
There was a problem hiding this comment.
nit , some of your methods have newline between attribute and method
danmoseley
reviewed
Apr 2, 2017
| Assert.Equal(result, lower.ToUpper().Equals(upper, StringComparison.Ordinal)); | ||
| } | ||
| } | ||
|
|
danmoseley
approved these changes
Apr 2, 2017
stephentoub
reviewed
Apr 3, 2017
| <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netcoreapp-Debug|AnyCPU'" /> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netcoreapp-Release|AnyCPU'" /> | ||
| <PropertyGroup> | ||
| <!-- we are overriding the .json config file --> |
Member
There was a problem hiding this comment.
Nit: it'd be good to include a "why" for this
|
|
||
| public void TestIndexOf(string source, string value, int startIndex, int count, CompareOptions options, int result) | ||
| { | ||
| foreach (var cul in s_cultureNames) |
Member
There was a problem hiding this comment.
Nit: var => string in this and other such cases
| } | ||
|
|
||
| private static string[] s_cultureNames = new string[] { "en-US", "ja-JP", "fr-FR", "tr-TR", "" }; | ||
|
|
| private static string[] s_cultureNames = new string[] { "en-US", "ja-JP", "fr-FR", "tr-TR", "" }; | ||
|
|
||
| public static IEnumerable<object[]> IndexOf_TestData() | ||
| { |
Member
There was a problem hiding this comment.
Don't we already have member data inputs for a bunch of these? Can we refactor them out of their current location and put them in a shared file that both projects can then just include?
Member
Author
There was a problem hiding this comment.
There is many differences compared to the data exist in other tests. this is the whole point for test invariant mode to ensure such differences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.