This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Force shim assembly references to 0.0.0.0#17363
Merged
stephentoub merged 1 commit intodotnet:masterfrom Mar 22, 2017
Merged
Conversation
The shims will end up being pulled into assembly closures where sometimes they will have a higher version of a dependency then what is actually needed. This causes msbuild (RAR) to output warnings which are just noise. For shims we really don't need the refenced to match exact versions so we can always force them to be the lowest version 0.0.0.0 and they will unify up to what is on the platform.
Member
|
LGTM |
stephentoub
approved these changes
Mar 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shims will end up being pulled into assembly closures where sometimes
they will have a higher version of a dependency then what is actually needed.
This causes msbuild (RAR) to output warnings which are just noise. For shims
we really don't need the refenced to match exact versions so we can always force
them to be the lowest version 0.0.0.0 and they will unify up to what is on
the platform.
cc @ericstj
I did some ad-hoc testing of this and verified that msbuild (RAR) no longer warns after this change it does AutoUnify and if that isn't enabled will cause a bunch of conflict warnings, but that is larger then just the shims.