Moving part of System.Security.Permissions down to System.Runtime.Extensions#13476
Moving part of System.Security.Permissions down to System.Runtime.Extensions#13476joperezr merged 2 commits intodotnet:masterfrom
Conversation
|
@dotnet-bot test Innerloop Linux ARM Emulator SoftFP Release Cross Build please |
| </ProjectReference> | ||
| <!-- Do not remove this P2P reference since part of the implementation of NonGeneric has moved to Runtime.Extensions --> | ||
| <ProjectReference Include="..\..\..\System.Runtime.Extensions\pkg\System.Runtime.Extensions.pkgproj" /> | ||
| <!-- ToDo: Remove this P2P reference once packages are updated --> |
There was a problem hiding this comment.
Why does it need S.Security.Permissions reference?
There was a problem hiding this comment.
Why does it need S.Security.Permissions reference?
I assume it's because the test projects now automatically reference everything, which means any time you move a type from assembly A to assembly B, you need to include P2P references for both A and B so that the test project doesn't see the type duplicated between the old package of A and the new assembly of B. I've run into that recently any time I've moved a type.
There was a problem hiding this comment.
Actually the reason is because Security.Permissions was still being referenced as part of the closure, but it was an older version that still had Security Attributes defined there, so need to reference both in order to have the compiler not to complain. Once we update packages, we can remove this.
stephentoub
left a comment
There was a problem hiding this comment.
We also need to move the tests for all types being moved.
Actually we don't want to do that, because if we do then we loose coverage for older configurations like netcoreapp1.0. That is why the paradigm we have been using so far is to keep the tests where they used to live, and just have that old project reference the live version of where the code now lives so that we keep testing live implementation. |
864c741 to
75594fa
Compare
|
The OSX Debug build succeeded, but it failed when archiving results. |
Fixes #13289
cc: @ianhays @weshaggard @danmosemsft
Moving netstandard 2.0 members of System.Security.Permissions down to System.Runtime.Extensions so that they are part of NETStandard.Library